feat: draft releases, version verification, and reusable workflows#287
feat: draft releases, version verification, and reusable workflows#287
Conversation
WalkthroughThis pull request updates release and PR validation workflows. It adds version consistency verification for tagged releases, configures Release Please to generate draft pull requests, replaces the release creation step with a reusable undraft workflow, and delegates PR title validation to a reusable workflow from the SDK generator repository. ChangesRelease Workflow & Version Verification
PR Title Validation Refactor
Possibly related PRs
Suggested reviewers
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the release/CI automation to support draft releases, add a tag/manifest/pyproject version consistency gate before publishing, and replace some in-repo workflow logic with reusable workflows from openfga/sdk-generator.
Changes:
- Configure release-please to create draft releases (
"draft": true). - Switch PR title conventional-commit validation to a reusable workflow.
- Add a
verify-versionjob before publishing on tag pushes and replace the release finalization step with an undraft reusable workflow.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| release-please-config.json | Enables draft behavior for release-please releases. |
| .github/workflows/pr-title-conventional-commit.yml | Replaces inline PR title validation with a reusable workflow. |
| .github/workflows/main.yaml | Adds version verification prior to publish and delegates undrafting to a reusable workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/main.yaml:
- Around line 120-125: The undraft-release job references a non-existent
workflow and will fail; update the job named undraft-release by either removing
the entire job block (undraft-release) or changing its uses value from
openfga/sdk-generator/.github/workflows/undraft-release.yml@main to the correct
workflow file openfga/sdk-generator/.github/workflows/release-please.yml@main
(and ensure any conditional/needs/permissions still apply) so the workflow
points to an existing release automation.
In @.github/workflows/pr-title-conventional-commit.yml:
- Around line 10-13: The referenced reusable workflow in the pr-title-check job
("uses: openfga/sdk-generator/.github/workflows/pr-title-check.yml@main") is
invalid and will fail at runtime; update the pr-title-check job by either
replacing the "uses" target with the correct reusable workflow path/name (or
correct repository) or remove the pr-title-check job and implement equivalent PR
title validation steps locally (e.g., a local step that validates commits/PR
title), ensuring changes are applied to the job named pr-title-check and its
"uses" entry.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 8d9ebb7e-6bc8-4f21-820f-a0ddf72fa517
📒 Files selected for processing (3)
.github/workflows/main.yaml.github/workflows/pr-title-conventional-commit.ymlrelease-please-config.json
Description
What problem is being solved?
How is it being solved?
What changes are made to solve it?
References
Review Checklist
mainSummary by CodeRabbit